Snow fix #424
Closed
Snow fix #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bors bot
added a commit
to CliMA/ClimaLand.jl
that referenced
this pull request
Sep 19, 2023
330: make snow tests more comprehensive, fix bug r=kmdeck a=kmdeck ## Purpose Investigate conservation of energy and water for the bucket model due to issues seen in the Coupler CliMA/ClimaCoupler.jl#424 CliMA/ClimaCoupler.jl#421 ## To-do ## Content - Add to test script for snow bucket conservation: run with nonzero precip, and with nonuniform evaporation field. - Fix bug in heaviside function - More care needed when tracking energy conservation. The energy in land is \rhoc_soil * \sum T_soil dz - \rho_l LH_f0*SWE. When snow falls on land, the energy changes because SWE changes, and we need to account for that in the test. This is not automatically accounted for because we dont have a snow energy variable (because we track SWE as the prognostic variable and the snow temperature is assumed to be the same as the freezing point). We also do not track the energy in the water on land, so there is no contribution for liquid precip. Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. ---- - [X] I have read and checked the items on the review checklist. Co-authored-by: kmdeck <[email protected]>
mitraA90
pushed a commit
to CliMA/ClimaLand.jl
that referenced
this pull request
Dec 22, 2023
330: make snow tests more comprehensive, fix bug r=kmdeck a=kmdeck ## Purpose Investigate conservation of energy and water for the bucket model due to issues seen in the Coupler CliMA/ClimaCoupler.jl#424 CliMA/ClimaCoupler.jl#421 ## To-do ## Content - Add to test script for snow bucket conservation: run with nonzero precip, and with nonuniform evaporation field. - Fix bug in heaviside function - More care needed when tracking energy conservation. The energy in land is \rhoc_soil * \sum T_soil dz - \rho_l LH_f0*SWE. When snow falls on land, the energy changes because SWE changes, and we need to account for that in the test. This is not automatically accounted for because we dont have a snow energy variable (because we track SWE as the prognostic variable and the snow temperature is assumed to be the same as the freezing point). We also do not track the energy in the water on land, so there is no contribution for liquid precip. Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. ---- - [X] I have read and checked the items on the review checklist. Co-authored-by: kmdeck <[email protected]>
|
Parent issue already closed by #435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #421