Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that initial conditions are continuous fields #435

Closed
Tracked by #359
juliasloan25 opened this issue Sep 25, 2023 · 0 comments · Fixed by #442
Closed
Tracked by #359

Check that initial conditions are continuous fields #435

juliasloan25 opened this issue Sep 25, 2023 · 0 comments · Fixed by #442
Assignees
Labels
🍃 leaf Issue coupled to a PR

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Sep 25, 2023

All tendencies must be continuous fields. We ensure this in the horizontal by calling DSS in each model at each timestep, and we ensure this in the vertical by providing continuous inputs. Since we don't have a function that can check if an input field is continuous, we should dss each of the initial states to make sure our initial conditions produce continuous fields.

See Simon's comment here for more details.

Addressed by #442

@juliasloan25 juliasloan25 added the 🍃 leaf Issue coupled to a PR label Sep 25, 2023
@juliasloan25 juliasloan25 changed the title Check that initial conditions are continuous Check that initial conditions are continuous fields Sep 25, 2023
@juliasloan25 juliasloan25 self-assigned this Sep 26, 2023
@bors bors bot closed this as completed in #442 Oct 3, 2023
@LenkaNovak LenkaNovak mentioned this issue Apr 15, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant