-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Covariant derivatives on GPU #1736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaysridhar
force-pushed
the
as/covar-deriv
branch
from
May 20, 2024 21:54
848e115
to
3dc35be
Compare
akshaysridhar
force-pushed
the
as/covar-deriv
branch
from
June 17, 2024 18:13
e0558aa
to
ea77cd9
Compare
akshaysridhar
force-pushed
the
as/covar-deriv
branch
from
July 22, 2024 15:58
ea77cd9
to
1d3f530
Compare
akshaysridhar
force-pushed
the
as/covar-deriv
branch
4 times, most recently
from
August 1, 2024 17:38
a556633
to
3d6b7b0
Compare
akshaysridhar
force-pushed
the
as/covar-deriv
branch
from
August 1, 2024 19:30
75e374e
to
6322356
Compare
akshaysridhar
force-pushed
the
as/covar-deriv
branch
3 times, most recently
from
August 5, 2024 16:48
4c8bbe9
to
56406b6
Compare
charleskawczynski
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I'm glad to see that the CPU/GPU are more unified with their results.
akshaysridhar
force-pushed
the
as/covar-deriv
branch
from
August 8, 2024 17:56
98b9ba1
to
8be268a
Compare
Thanks! I'll rebase + format and merge shortly. |
Adds unit tests (known trig solutions) for both cpu and gpu devices which compare parent array outcomes modified: ext/cuda/operators_sem_shmem.jl modified: ext/cuda/operators_spectral_element.jl modified: .buildkite/pipeline.yml modified: test/runtests.jl Relaxes test_broken on extruded CUDA operator tests (2 instances) Add 2 additional operator tests modified: test/Operators/hybrid/extruded_3dbox_cuda.jl modified: test/Operators/hybrid/extruded_sphere_cuda.jl Skip bounds check modified: ext/cuda/operators_spectral_element.jl
akshaysridhar
force-pushed
the
as/covar-deriv
branch
from
August 8, 2024 17:59
8be268a
to
014484a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the
spectralelement
operators ongpu
to work identically compared with their cpu implementations. Towards Christoffel symbol computations and consistent tensor divergence calculations.Removes two
broken
tags against cuda spectral element op tests following additions toext/cuda/operators_spectral_element.jl
.