-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LES experiments in ClimaAtmos #3059
Conversation
78e96a0
to
c47b9d4
Compare
8145994
to
304a17f
Compare
48fdc32
to
075bdc6
Compare
9e2e26f
to
e23c717
Compare
47b6ffc
to
68dd70f
Compare
d8fe8d3
to
c4d57c3
Compare
Preliminary 1M microphysics results (ClimaAtmos default ci-plot infrastructure used, with windowed time averages to avoid spin-up periods) |
6b3af24
to
62dbe8c
Compare
src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl
Outdated
Show resolved
Hide resolved
src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haakon-e LGTM!
aaf14ba
to
9a2bb44
Compare
9a2bb44
to
69ac28e
Compare
smagorinsky_lilly: | ||
help: "Smagorinsky-Lilly diffusive closure [`false` (default), `true`]" | ||
value: false | ||
c_smag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c_smag
is already a ClimaParameter, so let's not duplicate it here. This will also cause some confusion for users as there are two places to set c_smag
now.
SDI: #2999
This PR consolidates the key changes required to run ClimaAtmos in LES configurations. This links the changes in ClimaCore PR#1736 to updates in parameterized tendencies in ClimaAtmos.