Define local_geometry_type
#1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/local_geometry_type
branch
from
5cf6bd5 to
3e4bea6
Compare
charleskawczynski
force-pushed
the
ck/local_geometry_type
branch
from
3e4bea6 to
759f794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines,
local_geometry_type, which will allow us to migrate frommul_return_type/rmul_return_typetoBase.promote_op.local_geometry_typestatically returns the local geometry type, given a space type.This is a peel off from #1673, in case this may be needed to fix other inference issues (#1679, #1678, #1675).
None of this is actually being used yet, although I did add tests, because this seems to impact compiler inference, perhaps due to heuristics. I'm still digging into why. I've also defined a new version of
Operators.return_eltype, which I hope that we'll use in the long run.