Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some return types with Base.promote_op #1673

Closed
wants to merge 1 commit into from
Closed

Replace some return types with Base.promote_op #1673

wants to merge 1 commit into from

Conversation

charleskawczynski
Copy link
Member

This PR replaces mul_return_type and rmul_return_type with Base.promote_op.

@charleskawczynski
Copy link
Member Author

I think that this will break because I haven't changed the number of arguments in the other locations where Operators.return_type is called. But let's see.

@charleskawczynski charleskawczynski force-pushed the ck/promote_op branch 11 times, most recently from af8813a to 5cf6bd5 Compare April 16, 2024 18:07
@charleskawczynski charleskawczynski mentioned this pull request Apr 16, 2024
Merged
@charleskawczynski
Copy link
Member Author

Superseded by #1683

@charleskawczynski charleskawczynski deleted the ck/promote_op branch August 22, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisYatunin dennisYatunin dennisYatunin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @dennisYatunin