Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize matrix field broadcasting tests #1672

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

charleskawczynski
Copy link
Member

Supersedes #1616. This should hopefully shine light on what's going on.

@charleskawczynski charleskawczynski force-pushed the ck/speedup_ci branch 4 times, most recently from a2638ac to b6f67c5 Compare April 13, 2024 12:50
@charleskawczynski
Copy link
Member Author

@dennisYatunin, I think I may have run into this in the past: move variables or a function definition from inside @testset to outside, and JET gives different results. IIRC, function definitions outside of @testset more closely match what you see in applications.

Maybe I'm missing something, but it may be that these passing JET tests are actually a false positive pass because too many things are inside @testset. There have been issues with JET not detecting issues (aviatesk/JET.jl#608).

I'll need to dig into this more to confirm.

@charleskawczynski
Copy link
Member Author

Ahhh, the last build is not reaching the job that actually fails, so these inference tests are never reached. They're actually just failing on main. I'll make the 5 failing jobs soft fail, so that we at least hook in the tests that are being reached.

@charleskawczynski
Copy link
Member Author

@dennisYatunin, I'm going to move forward with merging this, please let me know if you want to follow up with any changes.

@charleskawczynski charleskawczynski merged commit fbf6942 into main Apr 15, 2024
15 checks passed
@charleskawczynski charleskawczynski deleted the ck/speedup_ci branch April 15, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant