Add timings to matrix field broadcasting #1616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
approved these changes
Feb 20, 2024
|
Hm, I think a better solution might be to split these tests out in our suite. That could reduce the time, allow the long ones to finish, and reveal which ones are really problematic. |
|
Superseded by #1672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds timings to the matrix field broadcasting. The first simple thing we could do is break this into a utilities function, and split up the tests into separate jobs. This would help, but these tests should probably be rewritten. They're allocating a bunch, it's not clear what's passing/broken/allocating from the output. The closures are probably not helping, and funny things can happen with JET tests inside
@testset. The first thing we can do is time each one, and see if there's a major outlier.