Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ClimaCoreMakie tests #1638

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix ClimaCoreMakie tests #1638

merged 1 commit into from
Mar 5, 2024

Conversation

charleskawczynski
Copy link
Member

Missed in #1632.

@Sbozzolo
Copy link
Member

Sbozzolo commented Mar 4, 2024

What's the difference, except for the imports?

@charleskawczynski
Copy link
Member Author

What's the difference, except for the imports?

I had used Geometry.ZPoint, assuming Geometry was in scope (but it wasn't), like most of the other tests.

@Sbozzolo
Copy link
Member

Sbozzolo commented Mar 4, 2024

Got it!

@charleskawczynski charleskawczynski merged commit 214a291 into main Mar 5, 2024
15 of 16 checks passed
@charleskawczynski charleskawczynski deleted the ck/cc_makie branch March 5, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @Sbozzolo