Remove deprecated methods. #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I think it would be useful to test some downstream packages before merging this |
Agreed, at least ClimaAtmos. |
charleskawczynski
force-pushed
the
ck/remove_dep_warn
branch
2 times, most recently
from
534ac3f to
ac0b7b7
Compare
Merged
Sbozzolo
reviewed
Mar 1, 2024
charleskawczynski
force-pushed
the
ck/remove_dep_warn
branch
2 times, most recently
from
e75051a to
e039a37
Compare
|
I have a PR in climaland to try this out and fix the issues (not many). Passing: https://buildkite.com/clima/climaland-ci/builds/3463 |
charleskawczynski
force-pushed
the
ck/remove_dep_warn
branch
from
c684d3c to
a0142af
Compare
Add to NEWS boundary_tags -> boundary_names kwarg Fixes
charleskawczynski
force-pushed
the
ck/remove_dep_warn
branch
from
a0142af to
4ec6aa9
Compare
|
Buildkite passed here. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a handful of deprecated methods. Since the next release will be a breaking release, we might as well rip off the band aid and remove some of the cruft.
Closes #1630.