Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aerosol radiation #3147

Merged
merged 2 commits into from
Jun 27, 2024
Merged

add aerosol radiation #3147

merged 2 commits into from
Jun 27, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Jun 26, 2024

Purpose

Add aerosols to radiation. For now we assume there is only sulfate aerosol.

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 force-pushed the zs/aerosol_radiation branch from a4b022e to 4b14be1 Compare June 26, 2024 19:55
@szy21 szy21 marked this pull request as ready for review June 26, 2024 21:51
@szy21 szy21 force-pushed the zs/aerosol_radiation branch from 4b14be1 to a5b936e Compare June 26, 2024 21:54
Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I just left one comment.

src/callbacks/callbacks.jl Show resolved Hide resolved
@szy21
Copy link
Member Author

szy21 commented Jun 27, 2024

@nefrathenrici I added an assert when building radiation cache, so that we only need to check it once at the beginning of the simulation. I need to pass in aerosol_names to radiation cache for this, but this is the best I can think of. What do you think?

@szy21 szy21 force-pushed the zs/aerosol_radiation branch from 849b1aa to b677197 Compare June 27, 2024 17:47
@szy21 szy21 enabled auto-merge June 27, 2024 18:20
@szy21 szy21 added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 0738db9 Jun 27, 2024
10 of 12 checks passed
@szy21 szy21 deleted the zs/aerosol_radiation branch June 27, 2024 19:21
@szy21 szy21 added the enhancement New feature or request label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants