Assert atmos to not have UnionAll types #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/gpu_compat
branch
from
a716d02 to
a0ccabd
Compare
|
Would it be possible to have this as unit test instead? |
It's possible, but then we would need to construct all the different instances that we make in CI to perform the tests (assuming we want it strictly enforced). |
charleskawczynski
force-pushed
the
ck/gpu_compat
branch
from
0c97cc0 to
d7dbcdb
Compare
charleskawczynski
force-pushed
the
ck/gpu_compat
branch
from
d7dbcdb to
317b4f6
Compare
charleskawczynski
force-pushed
the
ck/gpu_compat
branch
from
317b4f6 to
a0a092a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this can help with #2439. I'll need to fix the resulting errors.