Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization is broken with limiters on the GPU #2438

Open
charleskawczynski opened this issue Dec 15, 2023 · 4 comments
Open

Initialization is broken with limiters on the GPU #2438

charleskawczynski opened this issue Dec 15, 2023 · 4 comments
Labels

Comments

@charleskawczynski
Copy link
Member

charleskawczynski commented Dec 15, 2023

Build here: https://buildkite.com/clima/climaatmos-ci/builds/15369#018c6e50-62d1-46f8-af97-4c987d3b8092/149-222
(this was due to #2270), xref: #2270 (comment). cc @Sbozzolo. Generally we try to avoid UnionAll types like this, that need to be broadcasted, because they're not gpu compatible.

@charleskawczynski
Copy link
Member Author

I'll need to fix this before doing the dt sweep (if we're going to do it on the gpu)

@charleskawczynski
Copy link
Member Author

Maybe the broader issue is that we should add tests for testing that broadcasted structs do not have UnionAll types.

@Sbozzolo
Copy link
Member

Can we make the limiter a concrete type instead of UnionAll?

@charleskawczynski
Copy link
Member Author

Can we make the limiter a concrete type instead of UnionAll?

We would need Y to do that, which we don't have until after we've constructed numerics / atmos. For now, I'm proposing, in #2440, that we just use a mirror / singleton type to prescribe if and what limter will be constructed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants