Add AtmosNumerics #2270
Merged
Add AtmosNumerics #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
approved these changes
Oct 24, 2023
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
added a commit
that referenced
this pull request
Oct 25, 2023
2273: Move temporary variables in cache in `p.scratch` r=Sbozzolo a=Sbozzolo To be merged after #2270 Co-authored-by: Gabriele Bozzola <[email protected]>
Merged
Comment on lines
+100
to
+101
| limiter = | ||
| parsed_args["apply_limiter"] ? Limiters.QuasiMonotoneLimiter : nothing |
There was a problem hiding this comment.
By the way, @Sbozzolo, this is probably the reason for the increased allocations. Limiters.QuasiMonotoneLimiter is a UnionAll type, and the compiler can struggle with inference on these types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group a few numeric choices into a single object.