Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/sdk 3659/accessibility ids #556

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Task/sdk 3659/accessibility ids #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ef0540
task(SDK-3659) - Adds accessibility ids for inapp title, message, bgi…
Anush-Shand Feb 8, 2024
a0508bb
task(SDK-3659) - Adds accessibility ids for inapp icons
Anush-Shand Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions clevertap-core/src/main/res/layout-land/inapp_cover.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

<ImageView
android:id="@+id/backgroundImage"
android:contentDescription="inapp_bg_img"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_alignParentLeft="true"
Expand All @@ -21,6 +22,7 @@

<TextView
android:id="@+id/cover_title"
android:contentDescription="inapp_title"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_centerHorizontal="true"
Expand All @@ -33,6 +35,7 @@

<TextView
android:id="@+id/cover_message"
android:contentDescription="inapp_message"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_below="@+id/cover_title"
Expand Down Expand Up @@ -61,13 +64,15 @@

<Button
android:id="@+id/cover_button1"
android:contentDescription="inapp_btn1"
android:layout_width="220dp"
android:layout_height="46dp"
android:textSize="20sp"
android:visibility="gone" />

<Button
android:id="@+id/cover_button2"
android:contentDescription="inapp_btn2"
android:layout_width="220dp"
android:layout_height="46dp"
android:layout_marginLeft="22dp"
Expand All @@ -78,6 +83,7 @@
</RelativeLayout>

<com.clevertap.android.sdk.customviews.CloseImageView
android:contentDescription="inapp_close_btn"
android:layout_width="30dp"
android:layout_height="30dp"
android:layout_gravity="top|end"
Expand Down
1 change: 1 addition & 0 deletions clevertap-core/src/main/res/layout-land/inapp_cover_image.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
</RelativeLayout>

<com.clevertap.android.sdk.customviews.CloseImageView
android:contentDescription="inapp_close_btn"
android:layout_width="30dp"
android:layout_height="30dp"
android:layout_gravity="top|end"
Expand Down
5 changes: 5 additions & 0 deletions clevertap-core/src/main/res/layout-land/inapp_footer.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

<ImageView
android:id="@+id/footer_icon"
android:contentDescription="inapp_icon"
android:layout_width="78dp"
android:layout_height="78dp"
android:layout_marginLeft="20dp"
Expand All @@ -34,6 +35,7 @@

<TextView
android:id="@+id/footer_title"
android:contentDescription="inapp_title"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="20dp"
Expand All @@ -42,6 +44,7 @@

<TextView
android:id="@+id/footer_message"
android:contentDescription="inapp_message"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="10dp"
Expand All @@ -60,6 +63,7 @@

<Button
android:id="@+id/footer_button_1"
android:contentDescription="inapp_btn1"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="1"
Expand All @@ -68,6 +72,7 @@

<Button
android:id="@+id/footer_button_2"
android:contentDescription="inapp_btn2"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="1"
Expand Down
6 changes: 6 additions & 0 deletions clevertap-core/src/main/res/layout-land/inapp_half_interstitial.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

<ImageView
android:id="@+id/backgroundImage"
android:contentDescription="inapp_bg_img"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_alignParentLeft="true"
Expand All @@ -23,6 +24,7 @@

<TextView
android:id="@+id/half_interstitial_title"
android:contentDescription="inapp_title"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_centerHorizontal="true"
Expand All @@ -35,6 +37,7 @@

<TextView
android:id="@+id/half_interstitial_message"
android:contentDescription="inapp_message"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_below="@+id/half_interstitial_title"
Expand Down Expand Up @@ -66,6 +69,7 @@

<Button
android:id="@+id/half_interstitial_button1"
android:contentDescription="inapp_btn1"
android:layout_width="0dp"
android:layout_height="@dimen/inapp_button_height"
android:layout_weight="1"
Expand All @@ -74,6 +78,7 @@

<Button
android:id="@+id/half_interstitial_button2"
android:contentDescription="inapp_btn2"
android:layout_width="0dp"
android:layout_height="@dimen/inapp_button_height"
android:layout_marginLeft="20dp"
Expand All @@ -85,6 +90,7 @@
</RelativeLayout>

<com.clevertap.android.sdk.customviews.CloseImageView
android:contentDescription="inapp_close_btn"
android:layout_width="30dp"
android:layout_height="30dp"
android:layout_gravity="top|end"
Expand Down
1 change: 1 addition & 0 deletions clevertap-core/src/main/res/layout-land/inapp_half_interstitial_image.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
</RelativeLayout>

<com.clevertap.android.sdk.customviews.CloseImageView
android:contentDescription="inapp_close_btn"
android:layout_width="30dp"
android:layout_height="30dp"
android:layout_gravity="top|end"
Expand Down
5 changes: 5 additions & 0 deletions clevertap-core/src/main/res/layout-land/inapp_header.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

<ImageView
android:id="@+id/header_icon"
android:contentDescription="inapp_icon"
android:layout_width="78dp"
android:layout_height="78dp"
android:layout_marginLeft="20dp"
Expand All @@ -31,6 +32,7 @@

<TextView
android:id="@+id/header_title"
android:contentDescription="inapp_title"
android:layout_width="200dp"
android:layout_height="wrap_content"
android:layout_marginLeft="20dp"
Expand All @@ -41,6 +43,7 @@

<TextView
android:id="@+id/header_message"
android:contentDescription="inapp_message"
android:layout_width="200dp"
android:layout_height="wrap_content"
android:layout_marginLeft="20dp"
Expand All @@ -61,6 +64,7 @@

<Button
android:id="@+id/header_button_1"
android:contentDescription="inapp_btn1"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="1"
Expand All @@ -70,6 +74,7 @@

<Button
android:id="@+id/header_button_2"
android:contentDescription="inapp_btn2"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="1"
Expand Down
6 changes: 6 additions & 0 deletions clevertap-core/src/main/res/layout-land/inapp_interstitial.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

<TextView
android:id="@+id/interstitial_title"
android:contentDescription="inapp_title"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_centerHorizontal="true"
Expand All @@ -27,6 +28,7 @@

<ImageView
android:id="@+id/backgroundImage"
android:contentDescription="inapp_bg_img"
android:layout_width="214dp"
android:layout_height="120dp"
android:layout_below="@+id/interstitial_title"
Expand Down Expand Up @@ -56,6 +58,7 @@

<TextView
android:id="@+id/interstitial_message"
android:contentDescription="inapp_message"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_below="@+id/backgroundImage"
Expand Down Expand Up @@ -87,6 +90,7 @@

<Button
android:id="@+id/interstitial_button1"
android:contentDescription="inapp_btn1"
android:layout_width="0dp"
android:layout_height="@dimen/inapp_button_height"
android:layout_weight="1"
Expand All @@ -95,6 +99,7 @@

<Button
android:id="@+id/interstitial_button2"
android:contentDescription="inapp_btn2"
android:layout_width="0dp"
android:layout_height="@dimen/inapp_button_height"
android:layout_marginLeft="18dp"
Expand All @@ -106,6 +111,7 @@
</RelativeLayout>

<com.clevertap.android.sdk.customviews.CloseImageView
android:contentDescription="inapp_close_btn"
android:layout_width="30dp"
android:layout_height="30dp"
android:layout_gravity="top|end"
Expand Down
1 change: 1 addition & 0 deletions clevertap-core/src/main/res/layout-land/inapp_interstitial_image.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
</RelativeLayout>

<com.clevertap.android.sdk.customviews.CloseImageView
android:contentDescription="inapp_close_btn"
android:layout_width="30dp"
android:layout_height="30dp"
android:layout_gravity="top|end"
Expand Down
6 changes: 6 additions & 0 deletions clevertap-core/src/main/res/layout-sw600dp-land/inapp_cover.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

<ImageView
android:id="@+id/backgroundImage"
android:contentDescription="inapp_bg_img"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_alignParentLeft="true"
Expand All @@ -21,6 +22,7 @@

<TextView
android:id="@+id/cover_title"
android:contentDescription="inapp_title"
android:layout_width="262dp"
android:layout_height="wrap_content"
android:layout_centerHorizontal="true"
Expand All @@ -33,6 +35,7 @@

<TextView
android:id="@+id/cover_message"
android:contentDescription="inapp_message"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_below="@+id/cover_title"
Expand Down Expand Up @@ -61,13 +64,15 @@

<Button
android:id="@+id/cover_button1"
android:contentDescription="inapp_btn1"
android:layout_width="340dp"
android:layout_height="70dp"
android:textSize="20sp"
android:visibility="gone" />

<Button
android:id="@+id/cover_button2"
android:contentDescription="inapp_btn2"
android:layout_width="340dp"
android:layout_height="70dp"
android:layout_marginLeft="30dp"
Expand All @@ -78,6 +83,7 @@
</RelativeLayout>

<com.clevertap.android.sdk.customviews.CloseImageView
android:contentDescription="inapp_close_btn"
android:layout_width="40dp"
android:layout_height="40dp"
android:layout_gravity="top|end"
Expand Down
1 change: 1 addition & 0 deletions clevertap-core/src/main/res/layout-sw600dp-land/inapp_cover_image.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
</RelativeLayout>

<com.clevertap.android.sdk.customviews.CloseImageView
android:contentDescription="inapp_close_btn"
android:layout_width="40dp"
android:layout_height="40dp"
android:layout_gravity="top|end"
Expand Down
6 changes: 6 additions & 0 deletions clevertap-core/src/main/res/layout-sw600dp-land/tab_inapp_half_interstitial.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

<ImageView
android:id="@+id/backgroundImage"
android:contentDescription="inapp_bg_img"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_alignParentLeft="true"
Expand All @@ -23,6 +24,7 @@

<TextView
android:id="@+id/half_interstitial_title"
android:contentDescription="inapp_title"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_centerHorizontal="true"
Expand All @@ -35,6 +37,7 @@

<TextView
android:id="@+id/half_interstitial_message"
android:contentDescription="inapp_message"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_below="@+id/half_interstitial_title"
Expand Down Expand Up @@ -65,6 +68,7 @@

<Button
android:id="@+id/half_interstitial_button1"
android:contentDescription="inapp_btn1"
android:layout_width="0dp"
android:layout_height="@dimen/inapp_button_height"
android:layout_weight="1"
Expand All @@ -73,6 +77,7 @@

<Button
android:id="@+id/half_interstitial_button2"
android:contentDescription="inapp_btn2"
android:layout_width="0dp"
android:layout_height="@dimen/inapp_button_height"
android:layout_marginLeft="25dp"
Expand All @@ -84,6 +89,7 @@
</RelativeLayout>

<com.clevertap.android.sdk.customviews.CloseImageView
android:contentDescription="inapp_close_btn"
android:layout_width="40dp"
android:layout_height="40dp"
android:layout_gravity="top|end"
Expand Down
1 change: 1 addition & 0 deletions clevertap-core/src/main/res/layout-sw600dp-land/tab_inapp_half_interstitial_image.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
</RelativeLayout>

<com.clevertap.android.sdk.customviews.CloseImageView
android:contentDescription="inapp_close_btn"
android:layout_width="40dp"
android:layout_height="40dp"
android:layout_gravity="top|end"
Expand Down
Loading
Loading