-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/sdk 3659/accessibility ids #556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anush-Shand
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Anush-Shand
added a commit
that referenced
this pull request
Feb 21, 2024
* Extract API calls from NetworkManager * Add TriggerManager to NetworkManagerTests * task(SDK-3620) - Upgrades AGP to 8.2.1 * task(SDK-3620) - Resolves MissingClasses Detected while Running R8 for core * task(SDK-3620) - Setup workflows to use JDK 17 * task(SDK-3620) - Resolve workflow issues * task(SDK-3620) - Resolve workflow issues * Task/sdk 3639/refactor geofence unit tests (#547) * task(SDK-3639) - Refactors unit tests to remove powermock dependency, part 1 * task(SDK-3639) - Refactors unit tests to remove powermock dependency, part 2 * task(SDK-3639) - Refactors unit tests to remove powermock dependency, updates mockito version * task(SDK-3639) - Resolves case where CTGeofenceTaskManager unit tests were failing when run all together * task(SDK-3620) - Removes changes not specific to this task * task(SDK-3620) - Adds test namespace for core-sdk * task(SDK-3620) - Possible fix for failing git actions * task(SDK-3620) - Possible fix for failing git actions * task(SDK-3620) - Adds compileOptions for all modules * task(SDK-3536) - Changes inapp fragment transaction to commitNow() (#540) * task(SDK-3238) - Fixes Input PT by changing flag to MUTABLE (#544) * task(SDK-3620) - Adds agp 8 related consumer proguard rules for hms and baidu * task(SDK-3620) - Updates sample app * Lp/knock/anr jio (#548) * Bug: theoretical ANR due to synchronised method - my jio reported an anr trace which shows in register method of SDK - while there is nothing major happening to cause this anr, we are removing synchronised keyword because it seems not absolutely necessary. - Jira : https://wizrocket.atlassian.net/browse/SDK-3630 * Chore: Removal of log - removed log * Task/sdk-3622/upgrade to android 14 (#549) * task(SDK-3629) - Handles deprecated overridePendingTransitionMethod() * task(SDK-3238) - Adds activity options to PendingIntent.getActivity() * task(SDK-3238) - Updates compileSDKVersion and targetSDKVersion * task(SDK-3238) - Fixes unit tests by updating workflow files to target java version 17 * task(SDK-3238) - Fixes unit tests * task(SDK-3238) - Reverts changes * task(SDK-3238) - Fixes failing git actions * task(SDK-3238) - Reverts changes * task(SDK-3238) - Fixes unit tests * task(SDK-3622) - Removes targetSDKVersion and deprecated features * Task/sdk 3236/migrate to work manager (#542) * task(SDK-3236) - Initial implementation for migration to WorkManager * task(SDK-3236) - Adds main process check to before init push amo * task(SDK-3236) - Cleans the code and adds an instrumentation test * task(SDK-3236) - Removes redundant files * task(SDK-3236) - Cleans redundant code * task(SDK-3236) - Updates PushAmpWorker test * task(SDK-3236) - Updates logic for pingFrequencyUpdate * task(SDK-3236) - Updates pingFrequency * task(SDK-3236) - Adds comments and exception handling * task(SDK-3236) - Updates logic for stopping worker * task(SDK-3236) - Cancels jobscheduler jobs on app update * task(SDK-3236) - Moves constants to specific class, removes postAsyncSafely for ping event, improves logging, adds default flex interval * task(SDK-3236) - Optimizes SDF object creation * task(SDK-3236) - Optimizes SDF object creation * task(SDK-3620) - Updates build.gradle for test_shared module * Feat: Deprecated labels for xiaomi methods (#553) - xiaomi will be removed after March according to compliance * Workflow: Git actions for static checks (#555) * Task/sdk 3659/accessibility ids (#556) * task(SDK-3659) - Adds accessibility ids for inapp title, message, bgimg and btns * task(SDK-3659) - Adds accessibility ids for inapp icons --------- Co-authored-by: anush <[email protected]> * task(SDK-3620) - Updates AGP to 8.2.2 (#557) * task(SDK-3620) - Updates libs.versions.toml * task(SDK-3620) - Updates libs.versions.toml for kotlin_lpugin * Task/kotlin version (#559) * Feat: Removal of databinding - it was creating problems for sample app - kotlin version 1920 is required for databinding so we were forced * Feat: downgrading kotlin compilation version - downgrading kotlin compoilation version - it was forcing client to upgrade kotlin version in their project - "org.jetbrains.kotlin:kotlin-gradle-plugin" impacted * Docs/release cadence feb21 (#560) * Changelog: Xiaomi deprecations - deprecations added in xiaomi docs * Changelog: Xiaomi deprecations contd... - deprecations added in xiaomi docs * Changelog: Core SDK changelog * Changelog: Core SDK changelog * Changelog: SDK changelogs - push templates, geofence and huawei change logs updated. * Changelog: Core changelog * Changelog: FAQs updated * Changelog: Main changelog - hyperlinks individual ones * Versioning: SDK versions - bumped for new release - did for all but xiaomi sdks. * Chore: Copy templates - ran copy templates gradle command. * docs(SDK-3672) - Minor updates to docs --------- Co-authored-by: anush <[email protected]> * Docs/release cadence feb21 fix (#562) * Changelog: Xiaomi deprecations - deprecations added in xiaomi docs * Changelog: Xiaomi deprecations contd... - deprecations added in xiaomi docs * Changelog: Core SDK changelog * Changelog: Core SDK changelog * Changelog: SDK changelogs - push templates, geofence and huawei change logs updated. * Changelog: Core changelog * Changelog: FAQs updated * Changelog: Main changelog - hyperlinks individual ones * Versioning: SDK versions - bumped for new release - did for all but xiaomi sdks. * Chore: Copy templates - ran copy templates gradle command. * docs(SDK-3672) - Minor updates to docs * docs - Update changelog to include github issue fix --------- Co-authored-by: CTLalit <[email protected]> --------- Co-authored-by: Vassil Angelov <[email protected]> Co-authored-by: Darshan Pania <[email protected]> Co-authored-by: anush <[email protected]> Co-authored-by: Anush-Shand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://wizrocket.atlassian.net/browse/SDK-3658