Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix kickboxing and boxing technique conditions #78962

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

RedMisao
Copy link
Contributor

@RedMisao RedMisao commented Jan 5, 2025

Summary

Bugfixes "kickboxing and boxing technique conditions"

Purpose of change

(Fix #78915)
Kickboxing's tec_kickboxing_upper had a mismatched set of conditions for its description ("non-stunned + ±similar size + mundane" vs "non-stunned + ±similar size + no-flight")
Boxing's tec_boxing_upper is missing the "no-flight" condition to match its description

Describe the solution

Remove the "mundane" condition for the kickboxing uppercut and add the "no-flight" condition
Add the "no-flight" condition for the boxing uppercut

Describe alternatives you've considered

Don't take the custom "mundane" condition from kickboxing's uppercut

Testing

Additional context

From my little knowledge, a kickboxing uppercut is the same or virtually the same as a boxing uppercut. Someone with better IRL MA experience will know if they're divergent enough to justify it not being usable on the same group of enemies a boxing uppercut can

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Melee Melee weapons, tactics, techniques, reach attack astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 5, 2025
@Maleclypse Maleclypse merged commit f2be256 into CleverRaven:master Jan 5, 2025
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Melee Melee weapons, tactics, techniques, reach attack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kickboxing's uppercut definition doesn't match description text
2 participants