Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kickboxing's uppercut definition doesn't match description text #78915

Closed
morikal opened this issue Jan 2, 2025 · 1 comment · Fixed by #78962
Closed

Kickboxing's uppercut definition doesn't match description text #78915

morikal opened this issue Jan 2, 2025 · 1 comment · Fixed by #78962
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@morikal
Copy link

morikal commented Jan 2, 2025

Describe the bug

From the kickboxing json for the uppercut technique:

"//condition": "Things of similar size in both directions that keep their heads high",
"condition": {
"and": [
{
"math": [
"u_val('size') + 1 >= n_val('size')"
]
},
{
"math": [
"n_val('size') - 1 <= n_val('size')"
]
},
{
"not": {
"npc_has_effect": "stunned"
}
},
{
"or": [
{
"npc_bodytype": "human"
},
{
"npc_bodytype": "mi-go"
},
{
"npc_bodytype": "kangoroo"
},
{
"npc_bodytype": "horse"
},
{
"npc_bodytype": "bear"
},
{
"npc_bodytype": "angel"
}
]
},
{
"and": [
{
"not": {
"npc_has_species": "ZOMBIE"
}
},
{
"not": {
"npc_has_species": "NETHER"
}
},
{
"not": {
"npc_has_species": "NETHER_EMANATION"
}
},
{
"not": {
"npc_has_species": "LEECH_PLANT"
}
},
{
"not": {
"npc_has_species": "MIGO"
}
},
{
"not": {
"npc_has_species": "SLIME"
}
},
{
"not": {
"npc_has_species": "FUNGUS"
}
},
{
"not": {
"npc_has_species": "PLANT"
}
},
{
"not": {
"npc_has_species": "ROBOT"
}
},
{
"not": {
"npc_has_species": "CYBORG"
}
},
{
"not": {
"npc_has_species": "HALLUCINATION"
}
},
{
"not": {
"npc_has_species": "HORROR"
}
},
{
"not": {
"npc_has_species": "ABERRATION"
}
},
{
"not": {
"npc_has_species": "KRAKEN"
}
}
]
}
]
},
"condition_desc": "* Only works on a non-stunned target of similar size incapable of flight",

This appears to be a blend of both the boxing uppercut & snake kung fu's snake strike.
Boxing uppercut shares that first section (the 'or' between human, mi-go, etc) and the comment "//condition" as similar size things that keep heads high, and also the "condition_desc" is the same "* Only works on a non-stunned target of similar size incapable of flight".

Snake kung fu's snake strike is described as only working on mundane enemies, and has that long list of 'and' conditions (and not a zombie, and not a migo, etc).

I think either kickboxing's uppercut should work like boxing's, and the big section of "and not a zombie, not a migo, etc" should be taken out, or kickboxing's uppercut is meant to only work on mundane enemies and the condition_desc field should be updated to reflect that.

Attach save file

N/A

Steps to reproduce

N/A

Expected behavior

Expect the condition_desc of kickboxing's uppercut to reflect that it only works on mundane enemies or that the condition is updated to allow it to work on non-mundane enemies.

Screenshots

No response

Versions and configuration

N/A

Additional context

No response

@morikal morikal added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 2, 2025
@RedMisao
Copy link
Contributor

RedMisao commented Jan 5, 2025

Paraphrasing a bit, boxing's uppercut has one set of conditions (non-stunned, similar +- size enemy), snake kung fu's snake strike has another set of conditions (non-stunned, mundane, similar or smaller). Yet, kickboxing's uppercut has a combination of both (non-stunned, mundane, +- size enemy) with a description that matches the boxing technique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants