Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Add The Root of the Mountain trait for Ierde #78304

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Dec 2, 2024

Summary

Mods "[Xedra Evolved] Add The Root of the Mountain trait for Ierde"

Purpose of change

This is a trait I've wanted to add for a while.

Describe the solution

Add the trait, requiring The Mountain Does Not Move and either Vigor of the Stone or Vigor of the Mountain. When activated, the Ierde gains physical (and heat) armor and is immune to stunning, dazing, or downing, but cannot move.

I also added a couple messages to Ierde spells so it doesn't just say "You cast X"

Describe alternatives you've considered

Testing

Trait is applied and works properly.

However, it looks like the CANNOT_MOVE flag also stops you from attacking, so I'll need to make a bug report when this is merged.

Additional context

@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Dec 2, 2024
@github-actions github-actions bot requested a review from Maleclypse December 2, 2024 17:16
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You wide up and deliver a punch with the strength of a rockslide.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 2, 2024
@Maleclypse Maleclypse merged commit 723edad into CleverRaven:master Dec 3, 2024
21 of 27 checks passed
@Standing-Storm Standing-Storm deleted the ierde-immovable branch December 3, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants