-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ImGui version to 1.91.5 #78144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
label
Nov 25, 2024
mqrause
reviewed
Nov 25, 2024
github-actions
bot
added
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Info / User Interface
Game - player communication, menus, etc.
[C++]
Changes (can be) made in C++. Previously named `Code`
ImGui
Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds
json-styled
JSON lint passed, label assigned by github actions
labels
Nov 25, 2024
ZhilkinSerg
force-pushed
the
imgui-upgrade
branch
from
November 25, 2024 16:19
02fd666
to
ab4edcc
Compare
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Nov 25, 2024
ZhilkinSerg
force-pushed
the
imgui-upgrade
branch
from
November 25, 2024 20:13
ab4edcc
to
a32d5b9
Compare
github-actions
bot
added
the
Code: Build
Issues regarding different builds and build environments
label
Nov 25, 2024
ZhilkinSerg
force-pushed
the
imgui-upgrade
branch
from
November 25, 2024 20:25
a32d5b9
to
69422f7
Compare
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Nov 25, 2024
Bump imgui version from v1.89.6 to 1.91.5
ZhilkinSerg
force-pushed
the
imgui-upgrade
branch
from
November 25, 2024 23:53
69422f7
to
54f973d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Build
Issues regarding different builds and build environments
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
ImGui
Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds
Info / User Interface
Game - player communication, menus, etc.
json-styled
JSON lint passed, label assigned by github actions
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Upgrade ImGui to version to 1.91.5"
Purpose of change
Allow easier ImGui upgrades in the future. Also add missing license file.
Describe the solution
Upgraded ImGui to latest version and apply DDA/ImTui specific patches in a separate commit.
Additional context
We might want to migrate to docking branch (https://github.com/ocornut/imgui/tree/docking) in the future once more menus are migrated to imgui.