Imgui 1.89.6: User cannot resize the first column when ScrollY is enabled.

[Brambor]

Describe the bug

With Imgui 1.89.6, user cannot resize the first column when ScrollY is enabled.

See:
ocornut/imgui#6503

It could be fixed by merging new ImGui into CDDA, but I expect that to be a lot of work... Or not @katemonster33? I have no expectation of you fixing this, it is not that important anyway. I just want your estimate.

ImGui was merged just 2 weeks ago in #65709.

Attach save file

N/A

Steps to reproduce

See the issue

Expected behavior

Can resize any column. I can double-click the column for it to find it's smallest possible size.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.4046 (22H2)
• Game Version: 0.G-7935-g210b6c5d63-dirty [64-bit] (actually on master 3ccc5fa )
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth]
  ]

Additional context

No response

[katemonster33]

This should be pretty doable. My ImGui branch is here https://github.com/katemonster33/imgui but it needs to be updated and rebased with the latest code from cataclysm. Maybe I could look at this in the next few days

[katemonster33]

https://github.com/katemonster33/Cataclysm-DDA/tree/imgui_v1.90.4 i'm not going to make a PR since I don't have time to do regression testing, but let me know if this behaves any better for you

[Brambor]

https://github.com/katemonster33/Cataclysm-DDA/tree/imgui_v1.90.4 i'm not going to make a PR since I don't have time to do regression testing, but let me know if this behaves any better for you

This does resolve my issue! I will try to make a concise example soon™ to at least show it improves this aspect.

[Brambor]

I didn't bother making a minimal reproducible example.

I made a branch https://github.com/Brambor/Cataclysm-DDA/tree/imgui-1.90-solve-resize

Which is my project in progress implementing #69831. The last (three) commits should show the difference.

OLD a202e08 is the broken version.

NEW 24adf0b is the fixed version.

To reproduce the issue:

1. Compile on one of the commits.
2. Launch the game and load any save.
3. Go to keybindings and look for "Acquire graph" keybinding and bind it to some KEY.
4. Press KEY, it brings up a menu with a table.
5. The table has SEPARATORS as seen in the image.
   
6. You can double-click them to resize to optimal size in both versions.
7. In the NEW version you can drag to resize any SEPARATOR.
8. In the OLD version you cannot drag to resize the first SEPARATOR.

The NEW version:
https://github.com/CleverRaven/Cataclysm-DDA/assets/13402666/dd2de796-556c-41a3-b910-0d86f3b90318

[Brambor]

https://github.com/katemonster33/Cataclysm-DDA/tree/imgui_v1.90.4 i'm not going to make a PR since I don't have time to do regression testing, but let me know if this behaves any better for you

Anyway, I like it! I will take it as the ImGui base for now. My project has a long way to go anyway.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[katemonster33]

@Brambor what is your status on your project? do you need this new ImGui version soon?

[Brambor]

It will take about month or more, probably.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[Brambor]

@Brambor what is your status on your project? do you need this new ImGui version soon?

It would be nice to have. I might change inventory_selector to use ImGui, then resizing could be useful.

[katemonster33]

ok i can try and update my imgui version then

[Brambor]

https://github.com/Brambor/Cataclysm-DDA/tree/new-imgui

Merged master and fixed (newly merged) usage of renamed ActivateItemByID

Edit: I made a merge request: katemonster33#12

[Maleclypse]

Fixed by #78144