Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformation use action can pick random item from itemgroups #77893

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Transformation use action can pick random item from itemgroups #77893

merged 2 commits into from
Nov 17, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Nov 15, 2024 •
edited
Loading

Summary

None

Purpose of change

Close #76785

Describe the solution

Add such field

Testing

Used the field, seems to work
image

Additional context

transformation code is very ugly

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 15, 2024
mqrause
mqrause reviewed Nov 15, 2024
View reviewed changes
src/iuse_actor.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 15, 2024
@Maleclypse Maleclypse merged commit 9ac7d05 into CleverRaven:master Nov 17, 2024
21 of 27 checks passed
@GuardianDll GuardianDll deleted the annoying_karol branch November 17, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mqrause mqrause mqrause left review comments

@Night-Pryanik Night-Pryanik Night-Pryanik left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capability to use item transform actions with itemgroup IDs
4 participants
@GuardianDll @Night-Pryanik @mqrause @Maleclypse