Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability to use item transform actions with itemgroup IDs #76785

Closed
Karol1223 opened this issue Oct 2, 2024 · 1 comment · Fixed by #77893
Closed

Capability to use item transform actions with itemgroup IDs #76785

Karol1223 opened this issue Oct 2, 2024 · 1 comment · Fixed by #77893
Labels
<Suggestion / Discussion> Talk it out before implementing

Comments

@Karol1223
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I have recently tried to have an item transformation action for a mod that'd turn into one of multiple targets. This is currently unsupported, and may only be possible (even with Guardian's help we couldn't get it to work without errors) with EoCs.

Solution you would like.

It'd be handy to have the item transformation actions support itemgroup IDs directly to save me a headache.

Describe alternatives you have considered.

Suffer in EoC limbo

Additional context

No response

@Karol1223 Karol1223 added the <Suggestion / Discussion> Talk it out before implementing label Oct 2, 2024
@mqrause
Copy link
Contributor

mqrause commented Oct 2, 2024

It's definitely possible without EOCs. Transform actions already have members like variant_type or container that mirror the same functionality in item group modifiers. So there's potential to simplify the json a bit as well. Just the iuse_transform::do_transform needs a bit of a refactor to allow generating arbitrary itemgroups from an item, and of course if you really want to simplify the json that needs to be changed to item group syntax as well (but could be done by a script).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants