-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid starting fires on water tiles #77250
Forbid starting fires on water tiles #77250
Conversation
This is out of scope here but given the fact #76366 made liquid tiles configurable it might make sense to have a flag like |
Yes, good idea. |
Is lighting a boat on fire handled separately? |
@Psithief sorry for not answering for so long, I missed your question somehow. In my testing I temporarily allowed starting a fire on a boat, and it seems that fire is started not on a boat, but rather underneath it, i.e. on the water itself. This is confirmed by lighting a fire on a boat and then moving the boat several tiles away - the fire won't move with the boat, it will stay on the water tile. This is a problem much alike #21283 was a problem years ago. But even if you're planning to stay in place and don't move, fire doesn't behave as it should. It doesn't break boat parts, it doesn't eat up fuel, it slowly dies out. All in all, at the moment "fire in boat" situation is rather problematic to be allowed as is. I think we can/should open an issue regarding this stuff prior to allow starting fires in water vehicles. |
Port the original PR and make the checks a bit more granular Co-authored-by: Valiant <[email protected]> Ported from: CleverRaven/Cataclysm-DDA#77250
Port #77250 from CDDA Co-authored-by: Valiant <[email protected]> Ported from: CleverRaven/Cataclysm-DDA#77250
Summary
Bugfixes "Forbid starting fires (using firestarters) on water tiles"
Purpose of change
If you start fire in water no matter shallow or deep - it will burn and cannot be extinguished
statement from that issue on latest experimental as of 22 October 2024, I suppose not allowing to start a fire with help of firestarters on water tile is enough to close the issue.Describe the solution
Forbid starting fires (using firestarters) on water tiles. Also added a separate message for trying to start a fire on water.
Describe alternatives you've considered
Also forbid creating fire fields on water tiles through other means, for example flamethrowers, molotovs and magic?
Testing
Got a lighter and some splintered wood. Put the wood on tiles with shallow and deep water. Tried to light a fire on those tiles.
Additional context
None.