Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonifny water_from #76366

Merged
merged 3 commits into from
Sep 14, 2024
Merged

jsonifny water_from #76366

merged 3 commits into from
Sep 14, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Json power 💪
Close #75786

Describe the solution

Jsonify
Remove bunch of obsoleted flags
Rename water_from() to liquid_from()

Testing

Compiled, walked around checking different liquid source to see are they working as expected
image
image

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [Markdown] Markdown issues and PRs Mods: Mind Over Matter <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 11, 2024
@RedMisao
Copy link
Contributor

This means you can have any kind of "fountain of X" as long as X is a liquid ?

@GuardianDll
Copy link
Member Author

Yes

@Nebnis
Copy link
Contributor

Nebnis commented Sep 12, 2024

Finally i will be able to drink MoM black liquid pools, the anticipation is making me drool

@Maleclypse Maleclypse merged commit c0d5ef0 into CleverRaven:master Sep 14, 2024
27 of 28 checks passed
@GuardianDll GuardianDll deleted the json_liquid_source branch September 14, 2024 09:07
@GuardianDll GuardianDll mentioned this pull request Sep 14, 2024
Closed
@NetSysFire NetSysFire mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhardcode water_source to allow arbitrary liquid fields
4 participants
@GuardianDll @RedMisao @Nebnis @Maleclypse