Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TropiCata] Audit the remaining birds #76817

Merged
merged 15 commits into from
Dec 8, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Oct 4, 2024

Summary

None

Purpose of change

#75779 gave me power. Now I shall act on it.

Describe the solution

The general changes include but are not limited to:

  • adding dissection results for bird samples
  • updating factions to be more granular, as per Decentralize small_animal and fish factions #75993
  • updating the size and HP calculations
  • updating reproduction to match real world values
  • updating egg sizes and adding the eggs to the appropriate requirement group
  • renaming to be more clear which species are the monsters based off
  • in some cases, rewriting the descriptions to sound more natural

Affected tropical stinkers:

  • Rhea -> Greater Rhea
  • Quail - Removed - There are species of Quail native to Brazil, but they're not common at all, there's very little data on them online, I opted to exclude them
  • Tinamou -> Small-billed Tinamou
  • Seriema -> Red-legged Seriema
  • Chachalaca -> Chaco Chachalaca
  • Guan -> Dusky-legged Guan
  • Curassow -> Bare-faced Curassow

Other stuff:

  • Removed PATH_AVOID_FIRE from the bird abstract in vanilla because it's pointless, it's already included in PATH_AVOID_DANGER, just pathfinding has to be fixed first
  • Update factions for other birds
  • Destroy egg groups

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Food / Vitamins Comestibles and drinks Monsters Monsters both friendly and unfriendly. Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 4, 2024
@Karol1223 Karol1223 force-pushed the crimes-against-birds branch 2 times, most recently from bb19c6b to 46058c2 Compare October 4, 2024 20:55
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 4, 2024
@Karol1223 Karol1223 force-pushed the crimes-against-birds branch from 46058c2 to 0aeed6e Compare October 12, 2024 07:59
@github-actions github-actions bot added Spawn Creatures, items, vehicles, locations appearing on map BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 13, 2024
@Karol1223 Karol1223 force-pushed the crimes-against-birds branch from 7a4079a to b1ab67c Compare October 20, 2024 20:00
@Karol1223 Karol1223 force-pushed the crimes-against-birds branch from b1ab67c to bd4c65c Compare November 9, 2024 12:48
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 9, 2024
@Karol1223 Karol1223 force-pushed the crimes-against-birds branch from bd4c65c to 69df418 Compare November 19, 2024 14:10
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 19, 2024
@Karol1223 Karol1223 force-pushed the crimes-against-birds branch 2 times, most recently from a3acbe4 to 3240cad Compare December 6, 2024 09:48
@Karol1223 Karol1223 force-pushed the crimes-against-birds branch from 3240cad to a29e84c Compare December 6, 2024 09:51
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Chaco chachalaca
  • Chaco chachalaca egg
  • Chaco chachalaca eggs
  • Chaco chachalacas
  • Though its face looks oddly like a chicken's, complete with red wattle, this tan bird sounds nothing like one as it lets out raucous cries of 'chata-ra-ta.'

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Karol1223 Karol1223 force-pushed the crimes-against-birds branch from f55092f to f5e5dc1 Compare December 6, 2024 18:31
@Karol1223 Karol1223 marked this pull request as ready for review December 6, 2024 18:33
@Night-Pryanik Night-Pryanik merged commit 545788c into CleverRaven:master Dec 8, 2024
26 of 37 checks passed
@Karol1223 Karol1223 deleted the crimes-against-birds branch December 8, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants