-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decentralize small_animal
and fish
factions
#75993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Monsters
Monsters both friendly and unfriendly.
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
Mods
Issues related to mods or modding
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
labels
Aug 27, 2024
Karol1223
force-pushed
the
ungroup-the-rodents
branch
from
August 31, 2024 09:45
24c555a
to
89fbf1d
Compare
github-actions
bot
added
Code: Tests
Measurement, self-control, statistics, balancing.
[C++]
Changes (can be) made in C++. Previously named `Code`
labels
Aug 31, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 31, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Tests
Measurement, self-control, statistics, balancing.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods
Issues related to mods or modding
Monsters
Monsters both friendly and unfriendly.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
As I outlined in #75829 I wanted to decentralize
small_animal
to allow for better hunting simulation of small animals. This aims to achieve that.Describe the solution
Factions done:
Other changes:
vermin
faction as it served only as a base for the rat faction and gave me complications in theanimal_tiny
implementationmolerat
faction as it was an unused remnant of the mutant molerats I removed ages agoaggro_character: false
so it doesn't chase the player unless it is approached, only then it's provoked to attackherbivore
, to match other beaversdog_small
, as it is too small to zombify so it shouldn't be interesting to zombiesDescribe alternatives you've considered
Testing
Additional context
Currently a lot of this granularity goes unused. We have very few predators who differentiate between flightless/flying birds for example. This is okay because factions don't cause much if any overhang, but it allows us to possibly better simulate predator factions in the future.
The big issue is most predators we have are really not specialized at all. A raccoon or a fox isn't gonna care whether it's looking at a lizard or a bird chick. The granularity mainly comes in handy with semiaquatic predators like otters or snapping turtles, to make sure they don't go onto land too much.