Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decentralize small_animal and fish factions #75993

Merged
merged 13 commits into from
Sep 6, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Aug 27, 2024

Summary

None

Purpose of change

As I outlined in #75829 I wanted to decentralize small_animal to allow for better hunting simulation of small animals. This aims to achieve that.

Describe the solution

Factions done:

  • Mammals
  • Birds + Bat
  • Reptiles
  • Frogs
  • Fish

Other changes:

  • Removed vermin faction as it served only as a base for the rat faction and gave me complications in the animal_tiny implementation
  • Removed molerat faction as it was an unused remnant of the mutant molerats I removed ages ago
  • Halved the snake abstract's aggression since it turned out not to need it, and this way worm snakes won't anger the safemode popups
  • Gave the snapping turtle aggro_character: false so it doesn't chase the player unless it is approached, only then it's provoked to attack
  • Changed the monster the cormorant copied from to be in line with the other water birds
  • Moved the feaver to herbivore, to match other beavers
  • Moved the dachshund to dog_small, as it is too small to zombify so it shouldn't be interesting to zombies

Describe alternatives you've considered

Testing

Additional context

Currently a lot of this granularity goes unused. We have very few predators who differentiate between flightless/flying birds for example. This is okay because factions don't cause much if any overhang, but it allows us to possibly better simulate predator factions in the future.

The big issue is most predators we have are really not specialized at all. A raccoon or a fox isn't gonna care whether it's looking at a lizard or a bird chick. The granularity mainly comes in handy with semiaquatic predators like otters or snapping turtles, to make sure they don't go onto land too much.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions Mods Issues related to mods or modding Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) labels Aug 27, 2024
without bat, I wanna give that nerd a bird faction
@Karol1223 Karol1223 force-pushed the ungroup-the-rodents branch from 24c555a to 89fbf1d Compare August 31, 2024 09:45
@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` labels Aug 31, 2024
@Karol1223 Karol1223 marked this pull request as ready for review August 31, 2024 13:06
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 31, 2024
@Maleclypse Maleclypse merged commit d77e36d into CleverRaven:master Sep 6, 2024
23 of 28 checks passed
@Karol1223 Karol1223 deleted the ungroup-the-rodents branch September 6, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants