Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headlamp to accept medium batteries akin to a flashlight #76522

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

Br1ght0ne
Copy link
Contributor

Summary

Bugfixes "Fix headlamp to accept medium batteries akin to a flashlight"

Purpose of change

I noticed that the flashlight now uses medium batteries (56 max charge), and the headlamp still uses light/ultralight (16 max charge).

Describe the solution

I changed the headlamp to accept medium batteries, so, for instance, the battery from the flashlight used to craft the headlamp can be used.

Describe alternatives you've considered

Making flashlight run on light batteries again (defeats the battery overhaul I guess)

Testing

Crafted a headlamp from a flashlight which had a battery inside. Proceeded to reinsert the battery in the headlamp.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 18, 2024
@Br1ght0ne
Copy link
Contributor Author

Just noticed this comment on #76029 - I guess this fix will be handled together with other tool_armors.

@Night-Pryanik
Copy link

Your change broke some tests. Care to fix them?

@GuardianDll
Copy link
Member

I didn't know how to fix wearable_light properly, because the irl wearable flashlights i was able to find consumed 10 times more energy than flashlight, and wearable_light can be crafted using flashlight

@ampersand55
Copy link
Contributor

I didn't know how to fix wearable_light properly, because the irl wearable flashlights i was able to find consumed 10 times more energy than flashlight, and wearable_light can be crafted using flashlight

My findings were different, see #77394.

As for this PR, we should remove pocket for ultra-light batteries (2/2) as they fizzle out instantly.

@Night-Pryanik Night-Pryanik reopened this Nov 24, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 24, 2024
@Night-Pryanik Night-Pryanik merged commit 66af1cb into CleverRaven:master Nov 24, 2024
35 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants