-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweep of sanification for electronic devices #76029
Conversation
Regarding electrohack: we can probably justify it being UPS-only, rather having it use an external battery. UPS is kinda like USB anyway, isn't it? |
Does a regular flashlight have to run on a medium battery? |
Yes, i picked the flashlight that can use single 18650 specifically |
Could you please consider using a different flashlight model to base a heavy duty flashlight on? 5.4L is a very large volume. Maybe this? https://www.aliexpress.com/item/1005006026640261.html |
For what it's worth, this model is what I imagine when I think of that in-game item. However, even without accounting for the grip, it comes out to almost 4.2 L of volume. (4181.46 mL, to be precise.) |
If you are talking about the model I posted, its cylindrical volume (= without accounting for the grip) should be 3.14* (5.5cm**2) * 22cm = 2089 cubic cm = 2.089L. How do you reach a 4.2 L number? |
...by mixing up length and diameter in calculation, LOL. My bad! |
Your link return 404 |
it probably redirected you to aliexpress.ru here is amazon link to same item: This flashlight has complex shape. You cannot just multiply Product Dimensions as if it is just a box-shaped thing and expect calculated volume to be accurate |
it has complex shape, but since the game do not apply any volume penalties when you store multiple items of the same shape, we try to not calculate volume by displacement, but something like bounding hull; i can just decrease the volume of the original item by some margin because i indeed just multiplied three dimentions and called it a day |
ok. This should be added to doc somewhere then. As for switching to this other flashlight model: |
ok i checked it, and this one has much smaller capacity comparing to old one, this one supposed to have something around 17 kj only (while consuming only 3 W comparing to 5 W, but it doesn't compensate it fully) |
Further suggestions should either be posted as suggestion issues or PR'd elsewhere, this one is getting big enough as-is and we don't need to hold it up waiting to nitpick every little thing. Any further comments and reviews should be related to the existing changes in the PR or something already mentioned. Just a general heads-up for interested parties. |
@@ -195,7 +172,6 @@ | |||
"use_action": [ | |||
"EINKTABLETPC", | |||
"ELECTRICSTORAGE", | |||
"EBOOKSAVE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, eink readers do not have cameras, therefore should not have any capability to scan books
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, some models have cameras and even OCR software. I own one of those - PocketBook 650 (and I am pretty sure there are other models with cameras too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, i honestly failed to find such
if this exist, i think item can be revisited to give ebooksave back (and check it's power consumption, some books are too big for it to be scanned, which i think is incorrect)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While that's a neat device, I don't think it's a good general representation of e-ink tablets that you're likely to find in people's homes in the US.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harakka Do you refer to the ones with camera as being unlikely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Summary
Balance "Battery tools sanification"
Purpose of change
Because i can
Also fix #76038
Describe the solution
Check each battery-powered tool in cooking.json, electronics.json and lighting.json, and tweak it's stat to match some irl counterpart; tweak it's power consumption and the way it is recharged