Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep of sanification for electronic devices #76029

Merged
merged 20 commits into from
Sep 1, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Aug 29, 2024

Summary

Balance "Battery tools sanification"

Purpose of change

Because i can
Also fix #76038

Describe the solution

Check each battery-powered tool in cooking.json, electronics.json and lighting.json, and tweak it's stat to match some irl counterpart; tweak it's power consumption and the way it is recharged

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 29, 2024
@Hyperseeker
Copy link
Contributor

Regarding electrohack: we can probably justify it being UPS-only, rather having it use an external battery. UPS is kinda like USB anyway, isn't it?

@github-actions github-actions bot requested a review from Maleclypse August 29, 2024 12:29
@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership Items: Food / Vitamins Comestibles and drinks Items: Battery / UPS Electric power management Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Items: Containers Things that hold other things Mods: Xedra Evolved Anything to do with Xedra Evolved labels Aug 29, 2024
@HadeanLake
Copy link
Contributor

Does a regular flashlight have to run on a medium battery?

@GuardianDll
Copy link
Member Author

Yes, i picked the flashlight that can use single 18650 specifically

@x-qq
Copy link

x-qq commented Aug 30, 2024

Could you please consider using a different flashlight model to base a heavy duty flashlight on? 5.4L is a very large volume.

Maybe this? https://www.aliexpress.com/item/1005006026640261.html

hdf

@Hyperseeker
Copy link
Contributor

For what it's worth, this model is what I imagine when I think of that in-game item.

However, even without accounting for the grip, it comes out to almost 4.2 L of volume. (4181.46 mL, to be precise.)

@x-qq
Copy link

x-qq commented Aug 30, 2024

For what it's worth, this model is what I imagine when I think of that in-game item.

However, even without accounting for the grip, it comes out to almost 4.2 L of volume. (4181.46 mL, to be precise.)

If you are talking about the model I posted, its cylindrical volume (= without accounting for the grip) should be 3.14* (5.5cm**2) * 22cm = 2089 cubic cm = 2.089L. How do you reach a 4.2 L number?

@Hyperseeker
Copy link
Contributor

How do you reach a 4.2 L number?

...by mixing up length and diameter in calculation, LOL. My bad!

@GuardianDll
Copy link
Member Author

GuardianDll commented Aug 30, 2024

Your link return 404

@HadeanLake
Copy link
Contributor

HadeanLake commented Aug 30, 2024

Your link return 404

it probably redirected you to aliexpress.ru
you can find workarounds for your region if you google about it

here is amazon link to same item:
https://www.amazon.com/889C-Rechargeable-Flashlight-Searchlight-Waterproof/dp/B0CF1VVJNX

This flashlight has complex shape. You cannot just multiply Product Dimensions as if it is just a box-shaped thing and expect calculated volume to be accurate

@GuardianDll
Copy link
Member Author

it has complex shape, but since the game do not apply any volume penalties when you store multiple items of the same shape, we try to not calculate volume by displacement, but something like bounding hull; i can just decrease the volume of the original item by some margin because i indeed just multiplied three dimentions and called it a day

@HadeanLake
Copy link
Contributor

HadeanLake commented Aug 30, 2024

ok. This should be added to doc somewhere then.

As for switching to this other flashlight model:
8.3*4*6 *2.54^3 = 3264 ml - one bounding hull- box. A lot more manageable than the first flashlight
(4*4*8.3+2*2*8.3) *2.54^3 = 2720 ml - two boxes - the square WxW profile flashlight and the handle of same length and H-W square profile.
The second calculation is not that far away from the cylinder + properly sized solid block handle which I calculated to be 2448ml

@GuardianDll
Copy link
Member Author

GuardianDll commented Aug 30, 2024

ok i checked it, and this one has much smaller capacity comparing to old one, this one supposed to have something around 17 kj only (while consuming only 3 W comparing to 5 W, but it doesn't compensate it fully)
i''ll try to just tweak volume of original item instead

@RenechCDDA
Copy link
Member

Further suggestions should either be posted as suggestion issues or PR'd elsewhere, this one is getting big enough as-is and we don't need to hold it up waiting to nitpick every little thing. Any further comments and reviews should be related to the existing changes in the PR or something already mentioned.

Just a general heads-up for interested parties.

@github-actions github-actions bot added the Mods: Isolation Protocol ☣ The total conversion mod Isolation Protocol label Sep 1, 2024
@Maleclypse Maleclypse merged commit 9dfbd30 into CleverRaven:master Sep 1, 2024
22 of 26 checks passed
@GuardianDll GuardianDll deleted the after_battery branch September 1, 2024 22:07
Maleclypse added a commit that referenced this pull request Sep 4, 2024
@@ -195,7 +172,6 @@
"use_action": [
"EINKTABLETPC",
"ELECTRICSTORAGE",
"EBOOKSAVE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, eink readers do not have cameras, therefore should not have any capability to scan books

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, some models have cameras and even OCR software. I own one of those - PocketBook 650 (and I am pretty sure there are other models with cameras too).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, i honestly failed to find such
if this exist, i think item can be revisited to give ebooksave back (and check it's power consumption, some books are too big for it to be scanned, which i think is incorrect)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that's a neat device, I don't think it's a good general representation of e-ink tablets that you're likely to find in people's homes in the US.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harakka Do you refer to the ones with camera as being unlikely?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. Items: Armor / Clothing Armor and clothing Items: Battery / UPS Electric power management Items: Containers Things that hold other things Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Isolation Protocol ☣ The total conversion mod Isolation Protocol Mods: Xedra Evolved Anything to do with Xedra Evolved Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies NPC / Factions NPCs, AI, Speech, Factions, Ownership Spawn Creatures, items, vehicles, locations appearing on map Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flashlight lasts less than an hour