Rework river generation #74261
Closed
Rework river generation #74261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map / Mapgen
ZhilkinSerg
reviewed
Jun 2, 2024
This reverts commit 35b940e.
…d remove from ocean gen Rivers will naturally join the ocean without this and finding the northmost and southmost points of the closest east ocean doesn't exactly make any sense to begin with
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
|
Closing as stale. If you wish to continue working on this, ping me to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Reworked river generation to be more natural"
Purpose of change
Resurrect #38894
Describe the solution
Aims to get the nicer looking rivers from #38894 to a mergeable state
For now isn't attempting to solve #36630 / #59433
Describe alternatives you've considered
Testing
Compiles and loads, yields similar rivers to original PRs screenshots
Having an occasional hang that VS's debugger isn't catching
Additional context
I do find it pretty amusing that the author of the original PR came out of nowhere, made 3 really impactful PRs then disappeared before any of the got merged https://github.com/CleverRaven/Cataclysm-DDA/pulls?q=author%3ADiabolus-Engi
Random other peeves with existing water related overmap scale world gen:
I don't like that lake logic is pretty much completely disconnected from rivers logic
I don't like that rivers don't slightly favour flowing towards the nearest ocean
The river nodes should probably be tracked per river on a world scale
Rivers should be able to realistically merge rather than just cross
Lakes and wide rivers and should have variable depths, currently rivers never go lower than z0 while lakes go straight to z-5 after the shore omt
Cities should be able to span rivers
Streams should be connections so they can path to rivers
Water should actually flow in a direction so boats are less like reskinned cars
1 omt wide rivers should be supported