Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less insane river deltas #59433

Open
NetSysFire opened this issue Jul 20, 2022 · 4 comments
Open

Less insane river deltas #59433

NetSysFire opened this issue Jul 20, 2022 · 4 comments
Labels
Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! Map / Mapgen Overmap, Mapgen, Map extras, Map display (P5 - Long-term) Long-term WIP, may stay on the list for a while. <Suggestion / Discussion> Talk it out before implementing

Comments

@NetSysFire
Copy link
Member

Is your feature request related to a problem? Please describe.

image

When following a river, there is a good chance it will eventually escalate into a giant delta.

Solution you would like.

  1. New England has no such insane river deltas.
  2. There are no known river deltas this giant in the entire world.

In general, control branching of rivers. It might be related to why these insane deltas are created in the first place.

Describe alternatives you have considered.

No response

Additional context

No response

@NetSysFire NetSysFire added <Suggestion / Discussion> Talk it out before implementing Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jul 20, 2022
@natsirt721
Copy link
Contributor

This is probably out of scope, but in general, I'd like to see more smaller rivers and fewer large ones, in addition to reducing delta-ing. There are maybe a dozen waterways in the northeast over 100 yards wide for any meaningful stretch (Kennebec, Piscataqua, Merrimack, & Connecticut rivers come to mind), but it seems like in cata there is at least one good sized river running through every overmap. I'm not sure what a map tile is supposed to correspond to even roughly in terms of 'IRL distance' but they feel much too wide in most cases.

Many of the waterways in NE (speaking from personal experience living and hiking there, as well as many hours looking at satellite maps) are very small, no more than streams - yet this category of waterway is not modeled at all. This is especially true once you leave the coastal areas and get up into the more mountainous regions. Something akin to roads for water to break up the vast expanses of field and forest would provide a nice touch of verisimilitude.

@LovamKicsiGazsii
Copy link
Contributor

Might be unrelated, but #38894 attempted to fix river generation. I don't remember if it actually fixed river deltas, but the screenshots looked promising.

@JonathanLochridge
Copy link
Contributor

Might be unrelated, but #38894 attempted to fix river generation. I don't remember if it actually fixed river deltas, but the screenshots looked promising.

Interesting, It seems like a cool project. I am not sure why the PR opener closed it without merging it? I guess they couldn't get it to work or something?
It had two things on the todo list for the PR not completed from what I can tell.
Not remembering the river scale between maps is probably why it didn't get merged.
I am not sure how something like that would be fixed. But, it would be cool if someone who was more familiar with the C++ side of mapgen could implement that last bit to get that merged.

@NetSysFire NetSysFire added the Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! label Mar 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 2, 2023
@NetSysFire NetSysFire added (P5 - Long-term) Long-term WIP, may stay on the list for a while. and removed stale Closed for lack of activity, but still valid. labels Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! Map / Mapgen Overmap, Mapgen, Map extras, Map display (P5 - Long-term) Long-term WIP, may stay on the list for a while. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

4 participants