[MA] Starting a new game works again #73689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuardianDll
added
the
0.H Backport
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @ZhilkinSerg
github-actions
bot
added
astyled
Procyonae
force-pushed
the
MADisableOceans
branch
2 times, most recently
from
3abcf54 to
c6e0db2
Compare
github-actions
bot
added
Map / Mapgen
Procyonae
changed the title
github-actions
bot
added
the
BasicBuildPassed
Procyonae
changed the title
Merged
I-am-Erk
added a commit
that referenced
this pull request
May 21, 2024
Procyonae
added
0.H Backported
and removed
0.H Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MA] Starting a new game works again"
Purpose of change
Fixes #70526
Describe the solution
Disables ocean gen in MA
Locks the river/lake/ocean stuff in place_mongroups behind their external options
Removes misleading incorrect condition in region settings
Describe alternatives you've considered
Remembering to fix this months ago
Testing
Checked I could start a world fine
Additional context
Ideally the edge and infinite border of MA should be ocean rather than lake now, I'll look at sorting that in a separate PR tho
Edit: Zhilkin doesn't appear to have posted where they obtained the irl data from if anyone knows