Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massachusetts Mod can't start a new game on experimental build #70526

Closed
pjmsam opened this issue Dec 30, 2023 · 6 comments · Fixed by #73689
Closed

Massachusetts Mod can't start a new game on experimental build #70526

pjmsam opened this issue Dec 30, 2023 · 6 comments · Fixed by #73689
Labels
<Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: MA Massachussetts mod. Cata in one state (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@pjmsam
Copy link

pjmsam commented Dec 30, 2023

Describe the bug

When using Massachusetts Mod,it can't start a new game,it say unable to generate a valid starting location,
cdda1

Attach save file

N/A

Steps to reproduce

cdda1
start a new world with only Ma mod,build a character,and can't start the game

Expected behavior

fix the issue,thank,really don't want to go back play stable

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.3803 (22H2)
  • Game Version: 6ae463e [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

can't start with MA mod

Additional context

No response

@pjmsam pjmsam added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 30, 2023
@BrettDong BrettDong added Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: MA Massachussetts mod. Cata in one state labels Dec 31, 2023
@pjmsam
Copy link
Author

pjmsam commented Dec 31, 2023

it seems like SELECT_STARTING_CITY cause the "unable to generate a valid starting location" problem(which is true in MA mod). because even don't use MA mod but set
SELECT_STARTING_CITY to true will also cause this problem,

but even set it to false the MA mod still can't start ,please see the screenshot
image

this is the option cause the problem
{
"type": "EXTERNAL_OPTION",
"name": "SELECT_STARTING_CITY",
"info": "Allows to select starting city in new character menu.",
"stype": "bool",
"value": false
},

@Procyonae
Copy link
Contributor

/confirm

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Dec 31, 2023
@BrettDong BrettDong added the <Bug> This needs to be fixed label Jan 1, 2024
@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 3, 2024

I suspect this has somethingto do with oceans

@Procyonae
Copy link
Contributor

It could well do the MA maps stretch out pretty far. .omaps in general are working bc I'm having no problems with #70757. It could also specifically be related to the starting city stuff

@CavanStone
Copy link
Contributor

I suspect this has somethingto do with oceans

@I-am-Erk I think you are correct and here is my process for validating this:

  1. Start a new world and game with the Massachusetts Mod
  2. On the description tab of the character creation screen select a specific starting city [C] and choose Pittsfield
  3. Binary search the following list to find the coast using the debug option to teleport to city:
    [Pittsfield, Dalton, Hinsdale, Peru, Worthington, Cummington, Chesterfield, Goshen, Williamsburg, Northampton]
  4. Use Teleport to adjacent overmap and reveal map debug options to fine tune your position

I have validated this three times already. Here is my last attempt. As you can see the town of Cummington is close to the coast in the game when it is nowhere near the ocean in real life.

image

@CavanStone
Copy link
Contributor

@I-am-Erk

So there is a quick hacky fix for this.

  1. Copy over the core regional_map_settings.json file over to MA mod directory.
  2. Search the json file for "ocean_start_east" and change the value to 69 (the next overmap coordinate over from the outer cape shore.)
  3. Optionally change ocean_start_south to 42 (the next overmap coordinate from the south coast of Nantucket.) I swear I am not making these numbers up!

Here I am in Provincetown, in the latest experimental version:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: MA Massachussetts mod. Cata in one state (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants