Fixing issue where CJK text draws just a couple pixels too high on ImGui #73616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katemonster33
force-pushed
the
imgui_font_alignment
branch
from
a121f51 to
b67e9d8
Compare
github-actions
bot
added
Info / User Interface
NetSysFire
added
the
ImGui
github-actions
bot
added
the
BasicBuildPassed
SurFlurer
added a commit
to SurFlurer/Cataclysm-DDA
that referenced
this pull request
Aug 26, 2024
…o high on ImGui (CleverRaven#73616)" This reverts commit dacd72a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixing issue where CJK text draws just a couple pixels too high on ImGui"
Purpose of change
Fixes: #73061
Describe the solution
Modified the alignment modification when drawing CJK fonts on the screen using the ImGui "fallback" rendering.
Describe alternatives you've considered
Testing
Set language to Russian, verify that the text looks to be about the same height as any English characters around it (i.e. in the "Quit" popup verify that the parenthesis don't appear lower than the Russian text). Set language to Chinese, verify text doesn't draw too low.
Additional context