Restore drops to real spawned monsters that are meant to have them #72732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
|
Thank you for this. I was going to comment some way to allow the equivalent for the |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
#72718 removed item drops from monsters with temporary spawns, even in the case where those were real monsters and intended to drop corpses (or items, in the case of the portal storm artifact monsters).
Describe the solution
Give the drops back to those meant to have it.
Describe alternatives you've considered
Revert #72718?
Testing
Confirmed that a group of debug EOC-spawned monsters with lifespan dropped corpses when temporary_drop_items was set to true. (I used the yrax from the nether glass events, but changes to those are not in the final commit)
Additional context