Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOC temp monsters don't drop items or corpses by default #72718

Merged
merged 1 commit into from
Mar 30, 2024
Merged

EOC temp monsters don't drop items or corpses by default #72718

merged 1 commit into from
Mar 30, 2024

Conversation

anothersimulacrum
Copy link
Member

Summary

None

Purpose of change

Monsters with a lifespan are generally meant to disappear without leaving behind drops, so as to prevent abuse.
Fixes #72545

Describe the solution

Make monsters with a lifespan have a quiet death unless otherwise specified.

Testing

Create a f_impaled_officer, examine it (while indoors!) and touch it. See that the spawned soldiers no longer leave drops.

@anothersimulacrum
EOC temp monsters don't drop items or corpses
f36e8ee 
Unless explicitly told to. Monsters with a lifespan are generally meant
to disappear without leaving behind drops, so as to prevent abuse.
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 30, 2024
@dseguin dseguin merged commit 5a8cdec into CleverRaven:master Mar 30, 2024
25 of 28 checks passed
@anothersimulacrum anothersimulacrum deleted the temp-monsters-are-temp branch March 30, 2024 15:01
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 30, 2024
@RenechCDDA
Copy link
Member

I think we were a bit too quick on this one, there's several places that want the items to drop. This is also covered by the existing monsters definitions which can specify what the monster should or should not drop.

@RenechCDDA RenechCDDA mentioned this pull request Mar 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mercenary ghosts should not drop loots
3 participants
@anothersimulacrum @RenechCDDA @dseguin