-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fatigue to sleepiness #72708
Rename fatigue to sleepiness #72708
Conversation
I feel like this is going to break some stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @bombasticSlacks
Did you forget about the documentation? Or in a separate PR? |
Ugh. Forgot about it, thanks for the reminder |
This comment was marked as outdated.
This comment was marked as outdated.
data/json/ui/fatigue.json --> data/json/ui/sleepiness.json ? |
also catches a few bad f+r I missed
good catch, thanks idlesol |
Is renaming the field |
I had assumed the field was causing fatigue, but if it's supposed to be something else we should probably give it a different name entirely. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I really thought I got these already gr.
Summary
Infrastructure "Rename 'fatigue' to 'sleepiness', mostly on the back end, to avoid confusing different ways of being knackered"
Purpose of change
Part of #59858, see that issue for more details. Basically, we are modeling a lot of things already that are different ways of exhausting physical and mental resources: stamina, fatigue, weariness, focus... it gets very confusing, and unfortunately I really want to add one more. I think before doing that, we should try to do what we can to make it harder to confuse these things for each other.
Venera is more of an expert on airways than me and doesn't want me to name 'stamina' into 'breath' so I guess let's say:
closes #59858
Describe the solution
Renames "fatigue", which is very vague and describes anything from "my arms are tired" to "I need to sleep" to "that steel support is going to give way", into "sleepiness", which isn't my favourite term - it is a bit clunky - but should be hard to confuse for anything else.
This is the result of a large find-and-replace. i have tried to read through every change and make sure I didn't miss anything, but it definitely needs another look-over by someone else. I have made sure we didn't describe someone as wearing 'combat sleepiness', and in most descriptive text I've kept the word 'fatigue' unless I'm certain it's talking about need for sleep alone.
Also renamed fd_fatigue to fd_reality_tear, which may cause a json error or two, but I think is worth it for the clarity in code.
Describe alternatives you've considered
I considered 'drowsiness' as another option. I considered calling it just 'sleep' or 'sleepy' but they don't fit the structure we're using it in. "mod_sleepy" sounds stupid and unintuitive as a method.
Testing
The game compiles and runs without error
Additional context
I am fairly sure this is going to break something, but I haven't figured out what yet.