fix trapavoid monsters refusing to ever step on traps #72662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
Procyonae
added
the
0.H Backport
Procyonae
pushed a commit
to Procyonae/Cataclysm-DDA
that referenced
this pull request
May 20, 2024
fix trapavoid monsters refusing to ever step on traps
Merged
dseguin
added a commit
that referenced
this pull request
May 22, 2024
Procyonae
added
0.H Backported
and removed
0.H Backport
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Allow trap-avoiding monsters to step on traps if there's no other path"
Purpose of change
Fixes #71532, which was introduced by #68492. Monsters should be able to go
places that are dangerous if there is no other path available.
Describe the solution
Remove the
know_danger_atcheck frommonster::can_move_to. Just because atile is dangerous doesn't mean the monster can't step on it.
Describe alternatives you've considered
This can also be fixed by making
know_danger_atnot return false if the tileis a trap, but it does seem like a trap should be "known danger". I'm not totally
sure where
know_danger_atis used, so I'm not sure if that would have otherconsequences.
Testing
Tested the cases in #71532 and they all work now.
Additional context