Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better vehicle dragging #72515

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

RenechCDDA
Copy link
Member

Summary

None

Purpose of change

Describe the solution

Granularize the str_req so that there's a difference between dragging a wheel-less 1kg and a wheel-less 99kg object. Gameplay effect: Vehicles below 100kg are no longer anti-gravity devices.

Clamp the str_req for wheeled vehicles. If it's easier to push the thing without wheels... just don't use the wheels. Gameplay effect: It's no longer easier to push a cart with the wheels off.

Describe alternatives you've considered

Testing

I've been pushing carts and trucks around for like an hour now

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 20, 2024
src/grab.cpp Outdated Show resolved Hide resolved
@wormingdead
Copy link
Contributor

Maybe this is a bit nitpicky, but the commit message for 82eeea8 doesn't mention the value changes, which can make searching through the history difficult.

@Maleclypse Maleclypse merged commit 94b74cf into CleverRaven:master Mar 25, 2024
25 of 26 checks passed
@RenechCDDA RenechCDDA deleted the no_antigrav_shopping_carts branch March 26, 2024 05:39
@Procyonae Procyonae added the 0.H Backport PR to backport to the 0.H stable release canddiate label May 20, 2024
Procyonae pushed a commit to Procyonae/Cataclysm-DDA that referenced this pull request May 20, 2024
* Better pushing, with granularity

* better variable names
@Procyonae Procyonae mentioned this pull request May 20, 2024
Maleclypse added a commit that referenced this pull request May 21, 2024
@Procyonae Procyonae added 0.H Backported and removed 0.H Backport PR to backport to the 0.H stable release canddiate labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.H Backported astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

|| 4" Casters make moving a cart harder.
4 participants