[Magiclysm] Tweak spellcasting proficiency trigger #72484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Describe the solution
Change EVENT to ACTIVATION and delete the "spellcasting_finish" required_event
Describe alternatives you've considered
Continue letting errors happen?
Testing
Tested spellcasting, you only learn the correct proficiencies for each spell now, and no magiclysm proficiencies for spells from other mods. No more errors on spellcasting.
Additional context
Incredible thanks to @MNG-cataclysm for figuring out how to make the EOCs only trigger from their category of spells, that was definitely a bugfix beyond my own skills. I'm just glad to be able to tidy up some small errors.
Edit: Sorry about the weirdness in formatting for the purpose, I'm trying to figure out how to make the summary labeler not angry with me.