Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Tweak spellcasting proficiency trigger #72484

Merged

Conversation

rty275
Copy link
Contributor

@rty275 rty275 commented Mar 18, 2024

Summary

None

Purpose of change

  1. Closes [Magiclysm] Spellcasting proficiency EOCs run for every single spell #72428 in combination with [Magiclysm] Fix spellcasting proficiency setup triggers #72473
  2. With [Magiclysm] Fix spellcasting proficiency setup triggers #72473, the EOCs were correctly triggered by spell effects now, but still had the EVENT trigger of spellcasting_finish and were still triggering on every spell and now even throwing an error about having to use an ACTIVATION EOC. This fixes that.

Describe the solution

Change EVENT to ACTIVATION and delete the "spellcasting_finish" required_event

Describe alternatives you've considered

Continue letting errors happen?

Testing

Tested spellcasting, you only learn the correct proficiencies for each spell now, and no magiclysm proficiencies for spells from other mods. No more errors on spellcasting.

Additional context

Incredible thanks to @MNG-cataclysm for figuring out how to make the EOCs only trigger from their category of spells, that was definitely a bugfix beyond my own skills. I'm just glad to be able to tidy up some small errors.

Edit: Sorry about the weirdness in formatting for the purpose, I'm trying to figure out how to make the summary labeler not angry with me.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition labels Mar 18, 2024
@github-actions github-actions bot requested a review from KorGgenT March 18, 2024 17:34
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 18, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 18, 2024
@Maleclypse Maleclypse merged commit 04d5320 into CleverRaven:master Mar 22, 2024
19 of 25 checks passed
@rty275 rty275 deleted the bugfix-spellcasting-proficiency-trigger branch March 22, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Magiclysm] Spellcasting proficiency EOCs run for every single spell
2 participants