Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Spellcasting proficiency EOCs run for every single spell #72428

Closed
rty275 opened this issue Mar 16, 2024 · 0 comments · Fixed by #72484
Closed

[Magiclysm] Spellcasting proficiency EOCs run for every single spell #72428

rty275 opened this issue Mar 16, 2024 · 0 comments · Fixed by #72484
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@rty275
Copy link
Contributor

rty275 commented Mar 16, 2024

Describe the bug

All five of the spellcasting proficiency-learning EOCs run whenever you cast a spell from any mod.

Attach save file

Testing-trimmed.tar.gz

Steps to reproduce

  1. Check proficiencies
  2. Cast Knowing the Day and the Hour
  3. Check proficiencies again
  4. Debug remove proficiencies
  5. Cast Dream Dagger
  6. Check proficiencies again

Expected behavior

I would expect that you'd only learn the proficiencies for Magiclysm spells, and only learn the right one for each spell.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4170 (22H2)
  • Game Version: 31c9dbe [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Magiclysm [magiclysm],
    Xedra Evolved [xedra_evolved],
    Mind Over Matter [mindovermatter]
    ]

Additional context

This came up in the dev discord a little while ago and I forgot to put in a proper report until now, that's my bad. From discussion there, GuardianDll said that the math the EOCs are checking to run can only take numbers, the "_spell_id", "==", "eoc_evocation_setup" is assumed to be a variable and returns default 0 for each string. I may have explained that wrong, link to the discussion is here https://discord.com/channels/598523535169945603/598529538015887372/1215417677267468338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant