Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false eocs for running inv eocs #71953

Merged

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Feb 24, 2024

Summary

None

Purpose of change

Fix #70651

Describe the solution

The code was running the eoc on every failed item so instead its now just running it once.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 24, 2024
@GuardianDll
Copy link
Member

should fix #70145 also

@Fris0uman Fris0uman merged commit 1c518f3 into CleverRaven:master Feb 26, 2024
28 checks passed
@Ramza13 Ramza13 deleted the fix-false-eocs-for-run-inv-eoc branch March 10, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_inv_eocs runs more times than it should
3 participants