Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_inv_eocs runs more times than it should #70651

Closed
GuardianDll opened this issue Jan 4, 2024 · 2 comments · Fixed by #71953
Closed

run_inv_eocs runs more times than it should #70651

GuardianDll opened this issue Jan 4, 2024 · 2 comments · Fixed by #71953
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@GuardianDll
Copy link
Member

GuardianDll commented Jan 4, 2024

Describe the bug

As title says, for some reason next EoC runs not once, when you run it, but fixed amount of times, equal of items you have on you or in your inventory
replicated from #70566 use case

[
  {
    "type": "effect_on_condition",
    "id": "DEBUG_INV_BUG",
    "condition": { "math": [ "0", "==", "1" ] },
    "false_effect": [
      {
        "u_run_inv_eocs": "manual",
        "search_data": [ { "flags": [ "TRADER_AVOID" ] } ],
        "true_eocs": [ { "id": "U_CAN_PICK_TRADER_AVOID", "effect": [ { "u_message": "U_CAN_PICK_TRADER_AVOID" } ] } ],
        "false_eocs": [ { "id": "U_CANT_PICK_TRADER_AVOID", "effect": [ { "u_message": "U_CANT_PICK_TRADER_AVOID" } ] } ]
      }
    ]
  }
]

Attach save file

N/A

Steps to reproduce

Put beforementioned EoC in the game
Run it
Find it runs more than once

Expected behavior

Inventory EoC runs once

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.3803 (22H2)
  • Game Version: 0.G-6071-g60499ad017-dirty [64-bit] (originally 60499ad)
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response

@GuardianDll GuardianDll added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 4, 2024
Copy link
Contributor

github-actions bot commented Feb 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Feb 3, 2024
@RedMisao
Copy link
Contributor

It's happening to me too. The following EOC (launched via spell) should detect a single item as it's "wielded_only": true. However, it checks all items in the inventory at the moment of being launched:

  {
    "id": "iku_batteryrestore_eoc",
    "type": "effect_on_condition",
    "effect": [
      {
        "u_run_inv_eocs": "all",
        "search_data": [ 
          { "id": "light_minus_battery_cell", "wielded_only": true },
          { "id": "light_battery_cell", "wielded_only": true },
          { "id": "light_plus_battery_cell", "wielded_only": true },
          { "id": "medium_battery_cell", "wielded_only": true },
          { "id": "medium_plus_battery_cell", "wielded_only": true },
          { "id": "heavy_battery_cell", "wielded_only": true },
          { "id": "heavy_plus_battery_cell", "wielded_only": true }
        ],
        "true_eocs": [ "iku_batteryrestore_check" ],
        "false_eocs": [ 
          {
            "id": "batteryrestore_no",
            "effect": [ { "u_message": "You don't have a battery at hand.", "type": "mixed" } ]
          }
        ]
      }
    ]
  },

Dropping all items except for the light_minus_battery_cell while it is being wielded doesn't run the false_eocs. However, wearing clothes increases the u_message count by 1, each time the avatar puts on clothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants