Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Spell description changes #71294

Merged

Conversation

Milopetilo
Copy link
Contributor

@Milopetilo Milopetilo commented Jan 27, 2024

Summary

Mods "[Magiclysm] Change some spell description to feel more natural/be more accurate"

Purpose of change

I noticed that in #71236 the part of "lashing tentacles" was changed to the shoulders, but the description of the spell was unaffected. Then I noticed some of the descriptions for other spells were sometimes inaccurate or had weird sentences, so I tried to spruce them up a bit.

Describe the solution

Change the description of the spell to match its effects. Change some weirdly built sentences to (hopefully) easier to read ones.

Describe alternatives you've considered

Change it so the tentacles come out of your torso instead of shoulders.
Keep the descriptions the same.

Testing

Went in-game, noticed the changes happened in the spell descriptions.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 27, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 27, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 30, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 30, 2024
@Milopetilo Milopetilo marked this pull request as ready for review January 30, 2024 01:35
@github-actions github-actions bot requested a review from KorGgenT January 30, 2024 01:35
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 30, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 30, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Send a wave of high-frequency alternating pulses. It can't hurt living creatures, but is exceptional at stunning and destroying robots. Even though it isn't an EMP.
  • You fire a small concentrated ball of lightning at the target. The electricity diffuses rapidly, so it doesn't do much damage, but you're able to fire off several ones quickly.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Maleclypse Maleclypse merged commit fd88c9f into CleverRaven:master Feb 1, 2024
22 of 24 checks passed
@Milopetilo Milopetilo deleted the magiclysm-spell-descriptions branch February 5, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants