Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERCENTAGE_DAMAGE spells use the right bodypart's hp #71289

Merged

Conversation

Procyonae
Copy link
Contributor

Summary

None

Purpose of change

Fixes #57875

Describe the solution

Uses the same function as the eventual perfectly aimed hit does to ensure it works even on non humanoid body creatures.

Describe alternatives you've considered

Just using { body_part_torso }

Testing

Tested using a lvl 20 disruption bolt with "valid_targets": [ "self" ],
image

Additional context

@github-actions github-actions bot requested a review from KorGgenT January 27, 2024 13:31
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Enchantments / Spells Enchantments and spells <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 27, 2024
@Maleclypse Maleclypse merged commit 178d095 into CleverRaven:master Jan 31, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERCENTAGE_DAMAGE spell flag works incorrect for player
2 participants