Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERCENTAGE_DAMAGE spell flag works incorrect for player #57875

Closed
GuardianDll opened this issue May 23, 2022 · 4 comments · Fixed by #71289
Closed

PERCENTAGE_DAMAGE spell flag works incorrect for player #57875

GuardianDll opened this issue May 23, 2022 · 4 comments · Fixed by #71289
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@GuardianDll
Copy link
Member

Describe the bug

dealing damage for player with PERCENTAGE_DAMAGE flag works incorrect - it picks the max limb hp instead of current one

Steps to reproduce

  1. Make some self harming spell with PERCENTAGE_DAMAGE flag (for example, change the disruption_bolt to "valid_targets": [ "self" ])
  2. Give the character this spell
  3. Cast the spell
  4. Find it kills you way faster than it must

Expected behavior

Dealing a correct amount of damage

Screenshots

Self harm spell with 50% damage
The character
image
The character after the first cast
image
The character after the second cast
image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19044.1645 (21H2)
  • Game Version: 714cafd [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Magiclysm [magiclysm]
    ]

Additional context

PvE effect works fine
image

@GuardianDll GuardianDll added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label May 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Feb 4, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
@Procyonae
Copy link
Contributor

/confirm Looking into it

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid. labels Jan 27, 2024
@github-actions github-actions bot reopened this Jan 27, 2024
@Procyonae
Copy link
Contributor

Procyonae commented Jan 27, 2024

Would it be better if it hit all bodyparts rather than just the torso too? (That's probably out of scope looking at it but I might do it separately)

@Procyonae
Copy link
Contributor

So the issue is it's getting the current hp of the root body part which for the player and NPCs at least is the head but then it's damaging the torso by that amount so if you're at full hp on your head it will always do 50% of your head's max hp while in this image I've set my head hp to 1 and no longer take any damage
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants