Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove displacement field from engines #71263

Merged
merged 5 commits into from
Jan 27, 2024

Conversation

Milopetilo
Copy link
Contributor

@Milopetilo Milopetilo commented Jan 25, 2024

Summary

None

Purpose of change

Removing the old displacement field from engines, which has only been used for generating the volume prefix of the engine name since #65414.
Caught this while testing #71251.

Describe the solution

Removing displacement from engines and instead adding it directly to the name.
Also added a space between the value and unit.

Describe alternatives you've considered

Keeping it in case it's still needed somewhere I didn't catch.

Testing

Started the game up and saw the changes.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 25, 2024
@andrei8l

This comment was marked as resolved.

@github-actions github-actions bot added Vehicles Vehicles, parts, mechanics & interactions Code: Tests Measurement, self-control, statistics, balancing. labels Jan 26, 2024
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 26, 2024
@Milopetilo Milopetilo marked this pull request as ready for review January 26, 2024 11:57
@Maleclypse Maleclypse merged commit 76ef781 into CleverRaven:master Jan 27, 2024
41 checks passed
@Milopetilo Milopetilo deleted the Displacement branch January 27, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants