Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More SI unit spacing adjustments #71251

Merged
merged 8 commits into from
Jan 31, 2024

Conversation

Milopetilo
Copy link
Contributor

Summary

Interface "Change all SI units to follow SI unit rules, this time some items"

Purpose of change

Continuing on from #70905.

Describe the solution

Adjusting the spaces and units in the json files. Avoiding changing non user-facing strings, also not adding spaces to ammunition.

Describe alternatives you've considered

Testing

Went in-game and looked at items, descriptions were changed.

Additional context

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 25, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 26, 2024
@ZhilkinSerg
Copy link
Contributor

That is a rather big translation churn

@Milopetilo
Copy link
Contributor Author

I don't know how the translations are done. I'd gladly make these changes to the translations as well, if that could help lighten the load.

@Uwuewsky
Copy link
Contributor

Uwuewsky commented Jan 29, 2024

I can try to apply existing translations after merging this PR.

upd. damn sorry, msgmerge giving too much false positives

@Maleclypse Maleclypse merged commit 69fea8e into CleverRaven:master Jan 31, 2024
19 of 24 checks passed
@Milopetilo Milopetilo deleted the SI-adjustments branch January 31, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Info / User Interface Game - player communication, menus, etc. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants