-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poultry meat #70934
Add poultry meat #70934
Conversation
Hi sorry kinda busy with some stuff irl. Will get back to it soon. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
I messed up git-fu real bad and had to rebase. |
Time for testing, since I had none of the initial questions answered I expect to have to redo a lot of stuff, but here we go anyways. |
Hello, I've been keeping an eye on this since it's probably the closest to someone implementing bird meat in mainline Some suggestions for your bullet points (may overlap):
Suggestions for recipes: chicken pie, chicken pot pie, chicken nuggets/tenders (!), roasted whole bird (dunno how you would handle this, maybe the entire bird corpse item?), skewered chicken Also, you should also ask in the official discord for what more experienced people think about this |
Please don't. I understand why, but with this you're just adding a bunch more work for people who are gonna be working with birds next (me) as well as an extra currently useless abstract chick. Don't assume someone is gonna pick up where you left off. People rarely do that. If they want to do the thing, they'll do it by themselves. |
@Karol1223 Noted, all changes removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed these two missing prices before but once they have prices I think this is good to merge. Thank you!
@Maleclypse prices are in, thanks for catching it! |
They're literally still there chief |
@Karol1223 derp, appreciate the catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't find anything that seems wrong. I could complain about some item naming but honestly, it's good enough in my eyes. The mapgen tests are just throwing tantrums yet again.
ITS OVER |
Summary
Content "Add poultry meat"
Purpose of change
Bird meat is nutritionally distinct enough from meat from other land animals.
Also, fried chicken.
Describe the solution
Birds yield poultry meats. Can be smoked and dehydrated.
Bird meat was added to existing recipe requirement groups. To be revisited later on a followup PR.
8 new recipes that use poultry meat specifically.
A chunk of poultry is roughly "one portion," approx. 4oz or 100g for ease of usage in food recipes.
A scrap of poultry is 1/5th of a chunk, 20g, unlike scrap of meat which is 1/10th of a chunk.
Nutrition value is based on skin on, boneless, wild duck meat from USDA Database: https://fdc.nal.usda.gov/fdc-app.html#/food-details/174468/nutrients
List of new recipes
Describe alternatives you've considered
1. Lumping poultry meat and waterfowl meat together. This would mean that aquatic birds would simply yield more fat when butchered.2. Basing the nutrition value on another animal or another cut.3. Differentiating salmonella from food poisoning (in a future PR).
All poultry meat will be based on "wild" duck meat. It is close enough to domesticated chicken meat, which is what the survivor is most likely to farm/consume, and bridges the gap between lean birds and fatty waterfowl. Even though domesticated and farmed waterfowl like goose and duck approach 400kcal per portion, wild birds as the survivor is likely to hunt in the wild are not as calorically dense.
Testing
Additional context
Todo in a future PR: