Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Detect missions that are missing .start.assign_mission_target.om_special" errors #70845

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

BrettDong
Copy link
Member

@BrettDong BrettDong commented Jan 11, 2024

Summary

None

Purpose of change

Detect missions that are missing .start.assign_mission_target.om_special is failing on every pull requests recently: https://github.com/CleverRaven/Cataclysm-DDA/actions/workflows/assign_mission_target_needs_om_special.yml

Fix #70823

Describe the solution

The reason of the error is because #70682 added an overmaps entry that does not have a "overmap" field (the third entry below), causing null errors in jq matching.

{
    "type": "overmap_special",
    "id": "Boat Rental",
    "overmaps": [
      { "point": [ 0, 0, 0 ], "overmap": "boat_rental_north", "locations": [ "lake_shore" ] },
      { "point": [ 0, 0, 1 ], "overmap": "boat_rental_roof_north", "locations": [ "open_air" ] },
      { "point": [ 0, -1, 0 ], "locations": [ "land", "road" ] }
    ]
}

This pull request adds a filter to skip processing overmaps entries without "overmap" field.

Describe alternatives you've considered

Testing

Ran the test locally and it reported no error.

Additional context

@github-actions github-actions bot added Missions Quests and missions Code: Tooling Tooling that is not part of the main game but is part of the repo. labels Jan 11, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @jbytheway

@BrettDong BrettDong added the <Bugfix> This is a fix for a bug (or closes open issue) label Jan 11, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 11, 2024
@Maleclypse Maleclypse merged commit 59f8108 into master Jan 12, 2024
21 checks passed
@BrettDong BrettDong deleted the fix-assign-mission-target-check branch January 12, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequent test fail assign_mission_target_needs_om_special
2 participants